fix: made envs application actually NOP #691
Merged
+138
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decyjphr Another contribution from my company, We noticed this is an issue which people does not noticed and it impact environments. |
|
Any objection to this one @decyjphr ? I would love to see it merged. |
|
It looks like plugins have received an update to include an errors parameter so this plugin may not be 100% in line, if that's a problem I can update it sometime in the next week or so. |
|
Merge conflicts resolved. Ready to merge if possible. |
|
Thanks @randomcascade will look into merging this soon. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #551 Would love if someone else could validate the testing as I'm not sure I've tested every case.